Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed semicolon in readme #705

Merged
merged 1 commit into from Jul 1, 2020
Merged

fixed semicolon in readme #705

merged 1 commit into from Jul 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2020

9BB3E6B0-50B5-4480-A96A-E326F63E7275

ಠ_ಠ

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lpil lpil merged commit 0117c3a into gleam-lang:main Jul 1, 2020
@lpil
Copy link
Member

lpil commented Jul 1, 2020

Looks like this broke the fake syntax highlighting. Doh :(

I'll put it back until we have #477

lpil added a commit that referenced this pull request Jul 1, 2020
@ghost
Copy link
Author

ghost commented Jul 1, 2020

but it works for mdBook: gleam.run << https://github.com/gleam-lang/website/blob/master/src/README.md

so the problem is in Linguist's rust parser?

@lpil
Copy link
Member

lpil commented Jul 1, 2020

That's right, GitHub doesn't yet support Gleam

@ghost
Copy link
Author

ghost commented Jul 1, 2020

i mean the rust parsing/highlighting on github stops once it encounters "semicolon expected"
but in docs the same code also marked as rust, and mdBook highlights entire block regardless

@lpil
Copy link
Member

lpil commented Jul 1, 2020

Yes, that's right. I'm not sure why they do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants