Remove warning message #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the tests there is a warning message: ``` lib/i18n/tasks/scanners/base_scanner.rb:123: warning: instance variable @key_filter not initialized ``` In order to remove it: * Use `key_filter` method instead of the instance variable `@key_filter`
glebm
added a commit
that referenced
this pull request
Oct 22, 2014
bartimaeus
added a commit
to bartimaeus/i18n-tasks
that referenced
this pull request
Dec 1, 2014
* upstream/master: (39 commits) Tidy up the spec template indentation, use let(:unused_keys). Update README.md Added Gitter badge minor fix ignore_lines pattern travis: 2.1.1 -> 2.1.3 .travis latest jruby Bump to 0.7.8 Google Translate fixnum spec glebm#100 Improve ignore_lines glebm#96 glebm#102 initialize @key_filter glebm#101 Lines in HAML that start with # are skipped ignore config: better examples ru copy fix move error message to i18n YARD signatures for GoogleTranslation methods Possible fix for glebm#99 README: small fixes for defining custom commands Remove unused keys fix typo in gemspec [ci skip] Simplify commands DSL i18n ... Conflicts: spec/google_translate_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tests there is a warning message:
In order to remove it:
key_filtermethod instead of the instance variable@key_filter