Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use render html: instead of inline: #82

Closed
cantino opened this issue Apr 23, 2020 · 3 comments
Closed

Use render html: instead of inline: #82

cantino opened this issue Apr 23, 2020 · 3 comments
Labels
Bug

Comments

@cantino
Copy link

cantino commented Apr 23, 2020

By using render inline: here you may be introducing a RCE since it will evaluate ERB.

rails_email_preview/app/controllers/rails_email_preview/emails_controller.rb

Line 70 in 723c126

render inline: body, layout: 'rails_email_preview/email'

Is that intended?
@glebm
Copy link
Owner

glebm commented Apr 23, 2020

Good catch!

@glebm glebm added the Bug label Apr 23, 2020
glebm added a commit that referenced this issue Apr 23, 2020
@glebm
Use render html: instead of render inline:
b303af1 
Refs #82
@glebm
Copy link
Owner

glebm commented Apr 23, 2020

Fixed, released in https://github.com/glebm/rails_email_preview/releases/tag/v2.2.2

@glebm glebm closed this as completed Apr 23, 2020
@cantino
Copy link
Author

cantino commented Apr 23, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cantino @glebm