Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snake case runtimeInMilliseconds #22

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Request info in response.

### Changed
- **BREAKING**: Snake case `runtimeInMilliseconds`.

## [0.5.1] - 2023-03-10
### Added
- Uniqueness to custom "about" information.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ The endpoint will return data in JSON.
"slug": "database",
"group": "core",
"description": "Check all database connections.",
"runtimeInMilliseconds": 10,
"runtime_in_milliseconds": 10,
"result": {
"value": 1,
"message": "Connected to all databases.",
Expand Down
2 changes: 1 addition & 1 deletion src/Repository.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ private function checkToArray(Check $check): array
'group' => $check->group ?? 'other',
'description' => $check->description,
'result' => $check->run()->toArray(),
'runtimeInMilliseconds' => $start->diffInMilliseconds(),
'runtime_in_milliseconds' => $start->diffInMilliseconds(),
];
}

Expand Down
2 changes: 1 addition & 1 deletion tests/RepositoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function test_invoke_returns_correct_default_information()
'slug' => 'test-check',
'group' => 'other',
'description' => 'A test check',
'runtimeInMilliseconds' => 100,
'runtime_in_milliseconds' => 100,
'result' => [
'value' => null,
'message' => 'Looking good.',
Expand Down