Add user agent parameter to NewClient() #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This replaces the glesys-go user agent completely. If an application changes the ApplicationName there is no indication left that it is the glesys-go library that is in use. Perhaps |
emil-nasso
force-pushed
the
feature-application-name
branch
from
e277711 to
7766899
Compare
emil-nasso
changed the title
Artmann
approved these changes
Feb 13, 2017
dragontoe
approved these changes
Feb 13, 2017
emil-nasso
force-pushed
the
feature-application-name
branch
from
7766899 to
565a152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.