Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL to luxon text #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add URL to luxon text #176

wants to merge 1 commit into from

Conversation

parkxdavid
Copy link
Contributor

@parkxdavid parkxdavid commented Jan 24, 2024

Context

Make it easier to understand luxon date formatting by adding a hyperlink

Screenshot

SCR-20240124-oatw

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
glide-code-columns ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 9:00pm

@parkxdavid parkxdavid self-assigned this Jan 24, 2024
@parkxdavid parkxdavid requested a review from cif January 24, 2024 20:53
@parkxdavid parkxdavid added the enhancement New feature or request label Jan 24, 2024
@parkxdavid
Copy link
Contributor Author

parkxdavid commented Jan 24, 2024

@cif, not sure how to run glide locally and use this branch to test that my change is working properly in the product. Any tips?

@cif
Copy link
Contributor

cif commented Jan 24, 2024

For that change to render a link I suspect we'd have to convert the markdown in the string to HTML in the property configuration. If you create an issue for that I can look into it, might be a pretty simple change

@parkxdavid
Copy link
Contributor Author

Created the issue here: https://github.com/glideapps/glide/issues/25182

I just added the URL to see if it would work. I saw that there was a URL previously stored in withAbout with type string. Are you referring to making the change on the Glide side?

Screenshots

withAbout
SCR-20240124-pzpo

withAbout type
SCR-20240124-pzrs

@cif
Copy link
Contributor

cif commented Jan 25, 2024

Commented in the issue as well https://github.com/glideapps/glide/issues/25182#issuecomment-1910436021. Adding the markdown to the description field will be the way we want to enable this - the builder ignores the about field for yes code configs

Copy link
Contributor

@cif cif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ahead of https://github.com/glideapps/glide/pull/25188 needing to land in production, which I believe should happen today.

@parkxdavid
Copy link
Contributor Author

Nice! Do you want to merge this or should I once the other PR lands?

@cif
Copy link
Contributor

cif commented Jan 26, 2024

Looks like the prod deploy hasn't started yet and I'll be offline for a few hours. If you see it land feel to merge!

@parkxdavid
Copy link
Contributor Author

Looks like the prod deploy hasn't started yet and I'll be offline for a few hours. If you see it land feel to merge!

It landed! I would merge, but I'm not authorized apparently. Can you give me permissions?

@cif
Copy link
Contributor

cif commented Jan 29, 2024

I also lack permissions here, @timwellswa can you give us a hand when you get a second?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants