Merge pull request #1217 from glimmerjs/revert-1216-update-benchmark-…

…env-api Revert "[BREAKING] Update benchmark-env API"
glimmerjs · Dec 2, 2020 · 5787762 · 5787762
2 parents 5453b7b + 7c350cb
commit 5787762
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/benchmark/benchmarks/krausest/lib/index.js b/benchmark/benchmarks/krausest/lib/index.js
@@ -1,6 +1,8 @@
 import { createBenchmark } from '@glimmer/benchmark-env';
 
+import ApplicationTemplate from './components/Application.hbs';
 import Application from './components/Application';
+import RowTemplate from './components/Row.hbs';
 import Row from './components/Row';
 import buildData from './utils/data';
 
@@ -11,8 +13,8 @@ import buildData from './utils/data';
 export default async function render(element, isInteractive) {
   const benchmark = createBenchmark();
 
-  benchmark.basicComponent('Row', Row);
-  benchmark.basicComponent('Application', Application);
+  benchmark.basicComponent('Row', RowTemplate, Row);
+  benchmark.basicComponent('Application', ApplicationTemplate, Application);
 
   /** @type {{[name: string]: any}} */
   const args = {

diff --git a/packages/@glimmer/benchmark-env/src/create-benchmark.ts b/packages/@glimmer/benchmark-env/src/create-benchmark.ts
@@ -22,7 +22,7 @@ export default function createBenchmark(): Benchmark {
     templateOnlyComponent: (name) => {
       registry.registerComponent(name, null, TEMPLATE_ONLY_COMPONENT_MANAGER);
     },
-    basicComponent: (name, component) => {
+    basicComponent: (name, _template, component) => {
       registry.registerComponent(name, component, basicComponentManager);
     },
     render: registry.render,

diff --git a/packages/@glimmer/benchmark-env/src/interfaces.ts b/packages/@glimmer/benchmark-env/src/interfaces.ts
@@ -1,4 +1,4 @@
-import { Dict } from '@glimmer/interfaces';
+import { Dict, Template } from '@glimmer/interfaces';
 import { SimpleElement } from '@simple-dom/interface';
 
 /**
@@ -27,6 +27,7 @@ export interface Benchmark {
    */
   basicComponent<TComponent extends object = object>(
     name: string,
+    _template: Template,
     component: new (args: ComponentArgs) => TComponent
   ): void;