add tag info for ember-inspector

glimmerjs · Nov 28, 2023 · 80c34c3 · 80c34c3
1 parent 7c86dbd
commit 80c34c3
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/packages/@glimmer/validator/index.ts b/packages/@glimmer/validator/index.ts
@@ -13,7 +13,7 @@ if (globalObj[GLIMMER_VALIDATOR_REGISTRATION] === true) {
 globalObj[GLIMMER_VALIDATOR_REGISTRATION] = true;
 
 export { debug } from './lib/debug';
-export { dirtyTagFor, tagFor, type TagMeta, tagMetaFor } from './lib/meta';
+export { dirtyTagFor, infoForTag, tagFor, type TagMeta, tagMetaFor } from './lib/meta';
 export { trackedData } from './lib/tracked-data';
 export {
   beginTrackFrame,

diff --git a/packages/@glimmer/validator/lib/meta.ts b/packages/@glimmer/validator/lib/meta.ts
@@ -15,6 +15,13 @@ function isObjectLike<T>(u: T): u is Indexable & T {
 export type TagMeta = Map<PropertyKey, UpdatableTag>;
 
 const TRACKED_TAGS = new WeakMap<object, TagMeta>();
+const TAG_INFO = new WeakMap<
+  UpdatableTag | ConstantTag,
+  {
+    object: Object;
+    propertyKey: string | number | symbol;
+  }
+>();
 
 export function dirtyTagFor<T extends object>(
   obj: T,
@@ -67,5 +74,14 @@ export function tagFor<T extends object>(
     tags.set(key, tag);
   }
 
+  TAG_INFO.set(tag, {
+    propertyKey: key,
+    object: obj,
+  });
+
   return tag;
 }
+
+export function infoForTag(tag: UpdatableTag | ConstantTag) {
+  return TAG_INFO.get(tag);
+}
diff --git a/packages/@glimmer/validator/test/meta-test.ts b/packages/@glimmer/validator/test/meta-test.ts
@@ -1,4 +1,4 @@
-import { dirtyTagFor, tagFor, validateTag, valueForTag } from '@glimmer/validator';
+import { dirtyTagFor, infoForTag, tagFor, validateTag, valueForTag } from '@glimmer/validator';
 
 import { module, test } from './-utils';
 
@@ -18,4 +18,13 @@ module('@glimmer/validator: meta', () => {
 
     assert.notOk(validateTag(tag, snapshot));
   });
+
+  test('it can provide the object and property for the tag given object', (assert) => {
+    let obj = {};
+    let tag = tagFor(obj, 'foo');
+
+    let info = infoForTag(tag)!;
+    assert.strictEqual(info.object, obj);
+    assert.strictEqual(info.propertyKey, 'foo');
+  });
 });