Add exactOptionalPropertyTypes

glimmerjs · May 4, 2023 · 95edfd1 · 95edfd1
1 parent a81c716
commit 95edfd1
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/build/broccoli/write-smoke-test.js b/build/broccoli/write-smoke-test.js
@@ -33,6 +33,8 @@ class TypesSmokeTestWriter extends Plugin {
           noUnusedLocals: true,
           noUnusedParameters: true,
           noImplicitReturns: true,
+          useDefineForClassFields: true,
+          exactOptionalPropertyTypes: true,
 
           newLine: 'LF',
           noEmit: true,

diff --git a/packages/@glimmer/syntax/lib/traversal/errors.ts b/packages/@glimmer/syntax/lib/traversal/errors.ts
@@ -7,7 +7,7 @@ export interface TraversalError extends Error {
   key: string;
   node: ASTv1.Node;
   parent: Option<ASTv1.Node>;
-  stack: string | undefined;
+  stack?: string;
 }
 
 export interface TraversalErrorConstructor {
@@ -32,7 +32,10 @@ const TraversalError: TraversalErrorConstructor = (function () {
     this.message = message;
     this.node = node;
     this.parent = parent;
-    this.stack = error.stack ?? '';
+
+    if (error.stack) {
+      this.stack = error.stack;
+    }
   }
 
   return TraversalError as unknown as TraversalErrorConstructor;

diff --git a/packages/@glimmer/vm/tsconfig.json b/packages/@glimmer/vm/tsconfig.json
@@ -19,6 +19,8 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noImplicitReturns": true,
+    "useDefineForClassFields": true,
+    "exactOptionalPropertyTypes": true,
 
     "newLine": "LF",
     "noEmit": true,

diff --git a/tsconfig.json b/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     // Compilation Configuration
     "target": "es2020",
-    "lib": ["ES2020", "DOM"],
+    "lib": ["ES2020", "ES2022.Error", "DOM"],
     "inlineSources": true,
     "inlineSourceMap": true,
     "declaration": true,
@@ -22,7 +22,7 @@
     "noUnusedParameters": true,
     "noImplicitReturns": true,
     "useDefineForClassFields": true,
-    // "exactOptionalPropertyTypes": true,
+    "exactOptionalPropertyTypes": true,
     // "noImplicitOverride": true,
     // "noPropertyAccessFromIndexSignature": true,
     // "noUncheckedIndexedAccess": true,