[REFACTOR] Upstream custom managers, TO managers #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstreams custom component managers and TO component managers, and breaks managers in general out into their own package. This is necessary because managers need to be accessible from the opcode-compiler, which is itself upstream from `@glimmer/runtime`. `setComponentTemplate` is also moved into this package, as conceptually it is related - essentially everything about defining a component via composing its various parts should be in this package.
pzuraq
force-pushed
the
upstream-custom-and-to-managers
branch
from
6bc6c9a to
6ce5feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreams custom component managers and TO component managers, and
breaks managers in general out into their own package. This is necessary
because managers need to be accessible from the opcode-compiler, which
is itself upstream from
@glimmer/runtime.setComponentTemplateisalso moved into this package, as conceptually it is related -
essentially everything about defining a component via composing its
various parts should be in this package.
Breaking Changes
setComponentManager) have been moved to@glimmer/managergetComponentTemplateandsetComponentTemplatehave been moved to@glimmer/managerget*Managerfunctions have been replaced withgetInternal*Manager. In general, the VM now uses internal managers for everything.set*Managerfunctions intercept the public manager, wrap it, and then callsetInternal*Managerwith the wrapped manager.BaseInternalComponentManagerandBaseInternalModifierManagerhave been removed, along with theisInternalManagerfunctions. There's no longer any need to detect if a value is an internal manager, since we do this when we set the manager rather than when we get it.Other Changes
TemplateOnlyComponentManagerhas been upstreamed and is available from@glimmer/runtime