Fix evaluation stack off-by-one error introduced in #1293 #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before #1293, the `Load` operation would have popped the helper definition off of the evalution stack. After the #1293, nothing is popping it off anymore and that creates problem downstream. This balances things out by inserting a `Pop(1)` in the original frame. I couldn't think of a good way to test this, and this is blocking Ember beta, so we will merge this now (Ember has a test confirming this works) and @pzuraq will add a test later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #1293, the
Loadoperation would have popped the helper definition off of the evaluation stack. After the #1293, nothing is popping it off anymore and that creates problem downstream.This balances things out by inserting a
Pop(1)in the original frame.I couldn't think of a good way to test this, and this is blocking Ember beta, so we will merge this now (Ember has a test confirming this works) and @pzuraq will add a test later.