Simplify Stack (remove @glimmer/low-level package)
#1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the VM stack, removing the WasmStack and InnerStack in favor of a single stack. This stack no longer encodes values, so we don't need to maintain separate JS and handle stacks. Overall this simplifies the architecture and makes it easier to understand and maintain. In the future, when we do look into introducing WASM again, we can bring this separation of concerns back at that time.
rwjblue
approved these changes
Apr 23, 2021
rwjblue
changed the title
@glimmer/low-level package)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the VM stack, removing the WasmStack and InnerStack in favor
of a single stack. This stack no longer encodes values, so we don't need
to maintain separate JS and handle stacks. Overall this simplifies the
architecture and makes it easier to understand and maintain.
In the future, when we do look into introducing WASM again, we can
bring this separation of concerns back at that time.