Remove unnecessary property descriptor assertion from hash #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes an unnecessary property descriptor assertion, hash should work like a normal object (unlike args proxies) and so it should be allowed to read the property descriptors on it.
pzuraq
force-pushed
the
bugfix/remove-unnecessary-assertion
branch
from
f5717fd
to
fd561de
Compare
|
may resolve emberjs/ember.js#19130 |
|
This will not, this is related to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an unnecessary property descriptor assertion, hash should work
like a normal object (unlike args proxies) and so it should be allowed
to read the property descriptors on it.