Allow all (hash) keys to be set #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
bugfix/allow-all-values-on-hash-to-be-set
branch
4 times, most recently
from
00d9a55
to
0fcb6aa
Compare
rwjblue
requested changes
May 19, 2021
pzuraq
force-pushed
the
bugfix/allow-all-values-on-hash-to-be-set
branch
from
0fcb6aa
to
c85a42b
Compare
rwjblue
approved these changes
May 19, 2021
Enables setting all keys on a `(hash)`. We do this by creating a side-effecting cache which syncs the value of the key to the local state whenever it is first accessed, and checking that cache on all subsequent accesses. Whenever the upstream value has dirtied, the cache will rerun and overwrite the local state of the hash. When setting values on the hash with `Ember.get` and `Ember.set`, these functions will get and set the tags associated with the _proxy_ for those keys. This is why `customTagFor` has been updated to get and combine the tag for the proxy as well, for the time being.
pzuraq
force-pushed
the
bugfix/allow-all-values-on-hash-to-be-set
branch
from
c85a42b
to
2cbcabd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables setting all keys on a
(hash). We do this by creating aside-effecting cache which syncs the value of the key to the local state
whenever it is first accessed, and checking that cache on all subsequent
accesses. Whenever the upstream value has dirtied, the cache will rerun
and overwrite the local state of the hash.
When setting values on the hash with
Ember.getandEmber.set, thesefunctions will get and set the tags associated with the proxy for
those keys. This is why
customTagForhas been updated to get andcombine the tag for the proxy as well, for the time being.