Revert hash to bi-modal behavior #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reverts hash to it's bi-modal behavior prior to Ember ~3.22.
Hash will now:
1. Eagerly produce an object whenever used in JS, which consumes all
references and autotracks them. Whenever one reference changes, the
hash will dirty and produce a new object.
2. Lazily allow access to child paths in templates, e.g. `{{hash.foo}}`
will _not_ access any other references on the hash.
These behaviors have some quirks, but the quirks existed before 3.22 and
were primarily related to the fact that the object produced in 1 is
mutable and can diverge from the values in 2. Since setting values on a
hash object is deprecated, this should not be an issue in the near
future.
rwjblue
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts hash to it's bi-modal behavior prior to Ember ~3.22.
Hash will now:
references and autotracks them. Whenever one reference changes, the
hash will dirty and produce a new object.
{{hash.foo}}will not access any other references on the hash.
These behaviors have some quirks, but the quirks existed before 3.22 and
were primarily related to the fact that the object produced in 1 is
mutable and can diverge from the values in 2. Since setting values on a
hash object is deprecated, this should not be an issue in the near
future.