Remove deprecated support for mutation after consumption during certain manager hooks #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
force-pushed
the
sn/deprecate-tracking
branch
from
ac6a4ce
to
e6af391
Compare
| let end = nthIndex(e.stack, '\n', 4, updateStackBegin); | ||
| e.stack = e.stack.substr(0, start) + e.stack.substr(end); | ||
| } | ||
| // This hack makes the assertion message nicer, we can cut off the first |
There was a problem hiding this comment.
not related to this PR, but I wonder what is going on here -- why are we cutting of parts of the error message? are those parts ever needed?
rwjblue
changed the title
rwjblue
added a commit
to emberjs/ember.js
that referenced
this pull request
Sep 27, 2021
High level breaking changes: * `@glimmer/integration-tests`, `@glimmer/manager`, `@glimmer/validator` * [#1330](glimmerjs/glimmer-vm#1330) Remove deprecated support for mutation after consumption during certain manager hooks ([@snewcomer](https://github.com/snewcomer)) * `@glimmer/manager` * [#1328](glimmerjs/glimmer-vm#1328) Remove deprecated Component Manager version 3.4 ([@nlfurniss](https://github.com/nlfurniss)) * `@glimmer/integration-tests`, `@glimmer/manager` * [#1329](glimmerjs/glimmer-vm#1329) Remove deprecated Modifier Manager version 3.13 ([@nlfurniss](https://github.com/nlfurniss)) See full details here: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.81.0
rwjblue
added a commit
to emberjs/ember.js
that referenced
this pull request
Sep 29, 2021
High level breaking changes: * `@glimmer/integration-tests`, `@glimmer/manager`, `@glimmer/validator` * [#1330](glimmerjs/glimmer-vm#1330) Remove deprecated support for mutation after consumption during certain manager hooks ([@snewcomer](https://github.com/snewcomer)) * `@glimmer/manager` * [#1328](glimmerjs/glimmer-vm#1328) Remove deprecated Component Manager version 3.4 ([@nlfurniss](https://github.com/nlfurniss)) * `@glimmer/integration-tests`, `@glimmer/manager` * [#1329](glimmerjs/glimmer-vm#1329) Remove deprecated Modifier Manager version 3.13 ([@nlfurniss](https://github.com/nlfurniss)) See full details here: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.81.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes supporting infrastructure for allowing, but deprecating read after write in components and modifiers. Going forward, this will error with a message that you attempted to read then write in the same transaction.
Ref Ember.js issue: emberjs/ember.js#19617
Ember.js PR: emberjs/ember.js#19735