Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache head getter in PathExpressionImplV1 #1344

Merged
merged 1 commit into from
Oct 4, 2021

Commits on Oct 1, 2021

  1. Cache head getter in PathExpressionImplV1

    This is one of the hot paths during normalization, and it in turn calls
    the *hottest* paths of normalization (`hbsPosFor` and `hbsCharFor`).
    Adding this cache improves performance againt the baseline by nearly 50%
    of the current delta:
    
    |           variant            | average | min  | max  |
    | ---------------------------- | ------- | ---- | ---- |
    | @glimmer/compiler@0.65.3     | 6901.4  | 6812 | 6944 |
    | @glimmer/compiler@master     | 9000.4  | 8925 | 9041 |
    | @glimmer/compiler@experiment | 8144.8  | 8078 | 8240 |
    chriskrycho committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    729077d View commit details
    Browse the repository at this point in the history