Restore performance tests #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wycats
changed the title
wycats
force-pushed
the
chore/restore-perf-tests
branch
from
574553d
to
0919223
Compare
This commit prepares to re-enable perf tests. The intended strategy is to use vite to run the tests, using the built packages in the repo. This commit mostly focuses on build infrastructure. It builds on the existing rollup work, but uses turbo to speed up building and linting.
wycats
force-pushed
the
chore/restore-perf-tests
branch
from
c0de962
to
f39905d
Compare
wycats
force-pushed
the
chore/restore-perf-tests
branch
from
f39905d
to
c699046
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally intended to reactivate the performance tests. My plan was to run the tests through Vite, which revealed more inconsistencies with our module setup.
This PR continues #1426 by tightening up the lints, adding a number of lints to catch problems that were stopping the built modules from working in the vite setup in the performance suite. All of the lints now run on all packages (previously, the non-published packages had significantly weaker lints), and both the published and non-published packages now share an in-repo linting plugin to keep things consistent.
It also tightens up and solidifies the infrastructure that built the packages and
.d.tsfiles.There's still a bit more to do to finalize the
exportssetup that will be driven by finishing up the performance suite work.Since these changes are standalone improvements, I'm going to land this with the perf suite still disabled.