@glimmer/interfaces now uses extensions in its imports. #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Node16 consumers to use `@glimmer/interfaces`. None of the other `@glimmer/*` (vm) packages have this issue becaues they're all rollup'd to a single file. Rollup doesn't support .d.ts-only projects, and `tsc` doesn't support outputting to a single file in ESM projects (requires AMD or System `module` setting)
NullVoxPopuli
deleted the
use-explicit-extensions-to-support-Node16-environments-@glimmer-interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Node16 consumers to use
@glimmer/interfaces.None of the other
@glimmer/*(vm) packages have this issue becaues they're all rollup'd to a single file. Rollup doesn't support .d.ts-only projects, andtscdoesn't support outputting to a single file in ESM projects (requires AMD or Systemmodulesetting)Since the (almost) entirety of the VM repo uses moduleResolution=bundler, this (VM) repo should still provide us with sufficient confidence that non-Node16 projects still work with
@glimmer/interface's types.Unblocks: typed-ember/glint#696
cc @patricklx