-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements for keyed lists changes #945
Performance improvements for keyed lists changes #945
Conversation
mutations.map((item)=>{ return item.removedNodes.length ? ['-', item.removedNodes[0]] : ['+', item.addedNodes[0]] }).map(n=>{
n.push(n[1].textContent);
return n;
}) from <li>1</li><li>2</li><li>3</li><li>4</li><li>5</li> to <li>1</li><li>4</li><li>3</li><li>2</li><li>5</li>
for @Index test: |
looks like it's working like this: for muation index-0 - ok.
add 3 to index-2, for lists 1-8, 2->7, 7->2 if we found first changed ref, we trying to find last changed ref and invalidate middle? |
|
how fix work?
|
7787e73
to
fe950b9
Compare
630bf24
to
20bf405
Compare
@wycats is any updates/fixes I can add? |
@lifeart I'm taking a look at this today 😄 Thanks for all the effort! |
💥 |
this is failing tests related to #940
This PR must increase keyed lists swap perf up to 10x! Moon
(See swap rows row)
from this:
to this: