-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge SCSS in a single components.scss
file
#2608
Merge SCSS in a single components.scss
file
#2608
Conversation
I thought this would be relatively simple, but class definitions really have moved around a bunch… this is going to be a pain either way… and mastodon#28119 has 1200 line changes in |
de5cc30
to
b6b5aa9
Compare
I again spent many hours on this, and there are still many more hours to spend. I'm still not sure this is a good solution, considering the whole “monolithic SCSS” mess is awful, but the upshots are:
Still, it's a lot of work, and I'm afraid this will also push a large amount of work on downstreams. cc @kescherCode @TheEssem |
Well, we can't exactly cheat our way out of the upstream merge work, can we ^^ What must be done, must be done. |
b6b5aa9
to
c48f3a4
Compare
c48f3a4
to
189b70c
Compare
Making some progress. I basically reordered rules, refactored things a bit, applied some upstream changes that were somehow missed previously, removed some unintended duplicates as well as some dead code… and also introduced dead code that we removed but upstream was still holding on (though I have removed them upstream, so we'll get to that in a later merge. There are still significant differences, but most of them are due to actual feature/design/markup changes, so I'm considering either keeping them or tackling them in follow-up PRs. Broadly, the changes I can think of are:
|
components.scss
filecomponents.scss
file
c25a93e
to
d391e01
Compare
Doing this pains me, but one of the worst part of porting upstream changes is dealing with
components.scss
changes, as the contents are scattered across multiple files.