Reduce server load caused by anonymous viewing. #825
Conversation
Do not start a session if the current user is not logged in for public-facing pages. Mark pages that don't care about sessions as publicly cacheable. Keep the max age as 0 so proxies and browsers will still try to retrieve an updated version but can still fall back to the stale version if the site is down or too slow. Fixes mastodon#9035.
|
Is mastodon#9035 resolved? In particular, is the "change page after load using script" behavior, or something like it, implemented? |
|
This circumvents that issue by only telling proxies they can cache pages if no user is logged in. |
|
Ah, okay, I see now. Uh, I guess I'd like someone else to look at this, maybe give it a spin. It seems fine to me, but I haven't set up monitoring to see what percentage of requests are to potentially publicly cacheable pages on my own instance. (Well, really, I wonder what the numbers would be like on something more popular like glitch.social.) If there's no objections after a few days, I'll merge it in. There's at least one instance (https://mastodon.lubar.me) that's already running it. |
|
So the idea is to avoid starting sessions when that's not useful, and enable fallback caching for “public” pages, so that they can be served by a caching proxy should the instance go down. This looks like a good change, but I'm unsure about |
|
What's the word on this PR? I have no preference either way, but the code seems fine and it looks like it sets out what it meant to do. |
|
I'd rather have it modified to have the |
|
Closing, as it has been merged upstream (and also, does not work properly since |
Do not start a session if the current user is not logged in for public-facing pages.
Mark pages that don't care about sessions as publicly cacheable.
Keep the max age as 0 so proxies and browsers will still try to retrieve an updated version but can still fall back to the stale version if the site is down or too slow.
Ported from mastodon#9059