Skip to content

Commit

Permalink
Fix: use programId on reissue card AB#28068
Browse files Browse the repository at this point in the history
  • Loading branch information
PeterSmallenbroek committed May 14, 2024
1 parent 8d079a6 commit e690e23
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,16 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased](https://github.com/global-121/121-platform/compare/v1.119.0...main)
## [Unreleased](https://github.com/global-121/121-platform/compare/v1.119.1...main)

---

## [1.119.1](https://github.com/global-121/121-platform/compare/v1.119.0...v1.119.1)- 2024-05-14

### Fixed

- [AB#28067](https://dev.azure.com/redcrossnl/121%20Platform/_workitems/edit/28067) Use programId on reissue card

## [1.119.0](https://github.com/global-121/121-platform/compare/v1.118.0...v1.119.0)- 2024-05-14

### Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ export class IntersolveVisaService
const createDebitCardResult = await this.createDebitCard(
paymentDetails,
visaCustomer.visaWallets[0],
registration.programId,
);

const createDebitCardResultStatus = this.isSuccessResponseStatus(
Expand Down Expand Up @@ -694,6 +695,7 @@ export class IntersolveVisaService
private async createDebitCard(
paymentDetails: PaymentDetailsDto,
intersolveVisaWallet: IntersolveVisaWalletEntity,
programId: number,
): Promise<IntersolveCreateDebitCardResponseDto> {
const createDebitCardPayload = new IntersolveCreateDebitCardDto();
createDebitCardPayload.brand = 'VISA_CARD';
Expand All @@ -720,9 +722,8 @@ export class IntersolveVisaService

try {
// Added cover letter code during create debit card call
const coverLetterCode = await this.getCoverLetterCodeForProgram(
paymentDetails.programId,
);
const coverLetterCode =
await this.getCoverLetterCodeForProgram(programId);
createDebitCardPayload.coverLetterCode = coverLetterCode;
} catch (error) {
return {
Expand Down Expand Up @@ -1327,6 +1328,7 @@ export class IntersolveVisaService
const createDebitCardResult = await this.createDebitCard(
paymentDetails[0],
newWallet,
programId,
);
if (!this.isSuccessResponseStatus(createDebitCardResult.status)) {
// if this step fails, then try to block to overwrite the activation/unblocking from step 1/2, but don't throw
Expand Down

0 comments on commit e690e23

Please sign in to comment.