Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable strict mode on 121-service #5275

Merged
merged 2 commits into from
Jun 5, 2024
Merged

chore: enable strict mode on 121-service #5275

merged 2 commits into from
Jun 5, 2024

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented May 9, 2024 •
edited
Loading

AB#27995

Describe your changes

  • Turn on strict: true
  • Fix all compiler errors
  • ???
  • Profit

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines - please do not merge on my behalf

@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch from 2cad09a to eac9336 Compare May 9, 2024 15:15
@aberonni aberonni changed the base branch from main to aberonni/ts-goodies May 9, 2024 15:15
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch 4 times, most recently from 4613b74 to f212d4a Compare May 10, 2024 09:48
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch 3 times, most recently from ad3884a to 4ff8ab7 Compare May 10, 2024 11:07
@aberonni aberonni changed the base branch from aberonni/ts-goodies to aberonni/update-typescript May 10, 2024 11:07
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch 3 times, most recently from 63ebf36 to 0399fa3 Compare May 10, 2024 12:45
@aberonni aberonni force-pushed the aberonni/update-typescript branch from 4b33dce to 0bfbe0e Compare May 10, 2024 13:44
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch 4 times, most recently from fb7f3d9 to a7d94a0 Compare May 10, 2024 15:35
@aberonni aberonni force-pushed the aberonni/update-typescript branch 2 times, most recently from 0c86744 to dc19f0b Compare May 14, 2024 13:40
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch 2 times, most recently from 3bda874 to bb7e15a Compare May 14, 2024 14:06
Base automatically changed from aberonni/update-typescript to main May 14, 2024 14:07
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch from bb7e15a to 743f5e6 Compare May 14, 2024 14:08
@aberonni aberonni changed the base branch from main to aberonni/make-sure-isOptional-properties-are-marked-as-optional May 14, 2024 14:08
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch from 743f5e6 to 873aca6 Compare May 14, 2024 14:21
@aberonni aberonni force-pushed the aberonni/make-sure-isOptional-properties-are-marked-as-optional branch from 665889a to 48e8eda Compare May 14, 2024 14:38
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch from 873aca6 to 6721aac Compare May 14, 2024 14:39
@aberonni aberonni force-pushed the aberonni/make-sure-isOptional-properties-are-marked-as-optional branch from 48e8eda to 27443fd Compare May 14, 2024 14:42
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch from 8e85558 to 400cfe8 Compare May 30, 2024 12:03
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch from 400cfe8 to 2a9c46d Compare June 4, 2024 07:25
Base automatically changed from aberonni/swc to main June 4, 2024 07:56
@aberonni aberonni dismissed Vladimir-Petkov’s stale review June 4, 2024 07:56

The base branch was changed.

@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch from 2a9c46d to 7936476 Compare June 4, 2024 08:00
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch from 7936476 to 4edd8be Compare June 4, 2024 13:04
@aberonni
Copy link
Contributor Author

aberonni commented Jun 4, 2024

@ashishkumarbasak-accenture please see the changes in 023e6a3

ashishkumarbasak-accenture
ashishkumarbasak-accenture approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, it looks good to me. Approving!

@ashishkumarbasak-accenture
Copy link
Contributor

@aberonni Perhaps we can wait to merge this after tomorrow's deploy.

@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch from 023e6a3 to 84b1169 Compare June 5, 2024 08:53
@aberonni aberonni force-pushed the aberonni/enable-strictNullChecks branch from 84b1169 to 5b5c724 Compare June 5, 2024 12:54
@aberonni aberonni enabled auto-merge (squash) June 5, 2024 13:02
@aberonni aberonni merged commit 442e678 into main Jun 5, 2024
8 checks passed
@aberonni aberonni deleted the aberonni/enable-strictNullChecks branch June 5, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishkumarbasak-accenture ashishkumarbasak-accenture ashishkumarbasak-accenture approved these changes

@Vladimir-Petkov Vladimir-Petkov Vladimir-Petkov left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aberonni @ashishkumarbasak-accenture @Vladimir-Petkov