Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: physical card status color AB#28503 #5375

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

arsforza
Copy link
Contributor

@arsforza arsforza commented Jun 4, 2024

AB#28503

Describe your changes

fixes:

  • replaced ion-chip with badge
  • updated colors used in card status
  • applied wrap to card name to prevent status badge clipping in smaller screens

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo but for the rest looks pretty straightforward ✌️

Copy link
Member

@elwinschmitz elwinschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be even better to have a dedicated component for this (so we only have to do the "status-to-classname"-magic in 1 place;

But for now this is already an improvement. ;)

@elwinschmitz elwinschmitz force-pushed the fix.physical-card-status-color branch from a582366 to 4fb1b1e Compare June 10, 2024 10:29
@elwinschmitz elwinschmitz merged commit dabeef2 into main Jun 10, 2024
5 checks passed
@elwinschmitz elwinschmitz deleted the fix.physical-card-status-color branch June 10, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants