-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: physical card status color AB#28503 #5375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo but for the rest looks pretty straightforward ✌️
...nents/registration-physical-card-overview/registration-physical-card-overview.component.scss
Outdated
Show resolved
Hide resolved
...nents/registration-physical-card-overview/registration-physical-card-overview.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be even better to have a dedicated component for this (so we only have to do the "status-to-classname"-magic in 1 place;
But for now this is already an improvement. ;)
Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
a582366
to
4fb1b1e
Compare
AB#28503
Describe your changes
fixes:
Checklist before requesting a review