Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: process dependabot security alerts AB#28284 #5380

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

arsforza
Copy link
Contributor

@arsforza arsforza commented Jun 4, 2024

AB#28284

Describe your changes

  • Alert 291 solved by jimp update
  • Alert 424 solved by compodoc update
  • Alert 425 can't be fixed at the moment, the package needs to be patched properly

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

elwinschmitz
elwinschmitz previously approved these changes Jun 10, 2024
@arsforza
Copy link
Contributor Author

@elwinschmitz
Commit 6365aca touches the package that creates the voucher image.
I made a payment on my local environment for a PA with AH voucher and the image was created.
Please double check it's working on your end as well.

Copy link
Member

@elwinschmitz elwinschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically, now this(jimp-dev/jimp#1249) is in, we could refactor our workaround-the-euro-sign:
https://github.com/global-121/121-platform/blob/main/services/121-service/src/payments/imagecode/image-code.service.ts#L134-L142

But I don't think that is worth anything. ;)

@arsforza arsforza force-pushed the chore.dependabot-alerts-130 branch from 6365aca to 145984f Compare June 12, 2024 07:24
@arsforza arsforza merged commit 6fd119a into main Jun 12, 2024
4 checks passed
@arsforza arsforza deleted the chore.dependabot-alerts-130 branch June 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants