Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB#28497 e2e test #5382

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

XiaoyuSun-hub
Copy link
Contributor

@XiaoyuSun-hub XiaoyuSun-hub commented Jun 4, 2024

Describe your changes

Brief description of your changes - not in-depth because the bulk of the description should be in the task on DevOps.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Piotrk39 Piotrk39 force-pushed the test.update-phone-number-answer-with-invalid-value branch from cb85cac to 598a0d1 Compare June 5, 2024 11:56
@Piotrk39 Piotrk39 marked this pull request as ready for review June 5, 2024 11:57
Copy link
Contributor

@Piotrk39 Piotrk39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is more or less what we have discussed yesterday. Accepting!

@Piotrk39 Piotrk39 merged commit 1ff005d into main Jun 5, 2024
1 check passed
@Piotrk39 Piotrk39 deleted the test.update-phone-number-answer-with-invalid-value branch June 5, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants