Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB#28579 load programs fast #5398

Merged
merged 5 commits into from
Jun 13, 2024
Merged

AB#28579 load programs fast #5398

merged 5 commits into from
Jun 13, 2024

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Jun 11, 2024

AB#28579

Describe your changes

Load programs faster by doing less inefficient typeorm joins and only getting ids on the assigned programs endpoint

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

aberonni
aberonni previously approved these changes Jun 11, 2024
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the semplification! I added some comments but they are not must-haves.

Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor things - up to you if you wanna address them

@RubenGeo RubenGeo enabled auto-merge (squash) June 13, 2024 07:20
@RubenGeo RubenGeo force-pushed the feat.performance-program-page branch from 627582b to c7729d3 Compare June 13, 2024 07:20
@RubenGeo RubenGeo merged commit 2c5400f into main Jun 13, 2024
6 checks passed
@RubenGeo RubenGeo deleted the feat.performance-program-page branch June 13, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants