-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AB#28579 load programs fast #5398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aberonni
previously approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the semplification! I added some comments but they are not must-haves.
interfaces/Portal/src/app/pages/home/components/programs-list/programs-list.component.ts
Outdated
Show resolved
Hide resolved
interfaces/Portal/src/app/pages/home/components/programs-list/programs-list.component.ts
Outdated
Show resolved
Hide resolved
interfaces/Portal/src/app/pages/home/components/programs-list/programs-list.component.ts
Outdated
Show resolved
Hide resolved
aberonni
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor things - up to you if you wanna address them
RubenGeo
force-pushed
the
feat.performance-program-page
branch
from
June 13, 2024 07:20
627582b
to
c7729d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#28579
Describe your changes
Load programs faster by doing less inefficient typeorm joins and only getting ids on the assigned programs endpoint
Checklist before requesting a review