Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove user from team #5797

Merged
merged 12 commits into from
Sep 10, 2024
Merged

Remove user from team #5797

merged 12 commits into from
Sep 10, 2024

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Sep 9, 2024 •
edited by aberonni
Loading

AB#30158

Describe your changes

Tests against removing user from team

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Piotrk39 Piotrk39 added the portalicious Changes related to the portalicious release label Sep 9, 2024
@Piotrk39 Piotrk39 marked this pull request as ready for review September 10, 2024 07:49
@Piotrk39 Piotrk39 mentioned this pull request Sep 10, 2024
Closed
4 tasks
@aberonni aberonni self-requested a review September 10, 2024 08:54
aberonni
aberonni requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few syntax changes but the logic looks great. I'm really happy that we are testing this stuff so thoroughly :)

e2e/portalicious/pages/ProjectTeam.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/ProjectTeam.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/ProjectTeam.ts Outdated Show resolved Hide resolved
e2e/portalicious/tests/ManageTeam/RemoveUserFromTeam.spec.ts Outdated Show resolved Hide resolved
e2e/portalicious/tests/ManageTeam/RemoveUserFromTeam.spec.ts Outdated Show resolved Hide resolved
services/121-service/src/seed-data/program/program-test-one-admin.json Show resolved Hide resolved
Piotrk39 and others added 10 commits September 10, 2024 13:06
@Piotrk39
AB#30150 add e2e test and new seed script
b364a9d
@Piotrk39
AB#30157 add E2E test
4abbb39
@Piotrk39
AB#30157 remove wait add validate toast
3516606
@Piotrk39
AB#30158 add test
29a21c9
@Piotrk39
AB#30158 finalise test add headless run
5c91954
@Piotrk39 @aberonni
Update e2e/portalicious/pages/ProjectTeam.ts
f87b57b 
Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
@Piotrk39 @aberonni
Update e2e/portalicious/pages/ProjectTeam.ts
662a11e 
Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
@Piotrk39 @aberonni
Update e2e/portalicious/tests/ManageTeam/RemoveUserFromTeam.spec.ts
540ad28 
Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
@Piotrk39 @aberonni
Update e2e/portalicious/tests/ManageTeam/RemoveUserFromTeam.spec.ts
94f9ebb 
Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
@Piotrk39 @aberonni
Update e2e/portalicious/pages/ProjectTeam.ts
225350e 
Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
@Piotrk39 Piotrk39 enabled auto-merge (squash) September 10, 2024 11:07
@Piotrk39 Piotrk39 merged commit 20a87ea into main Sep 10, 2024
7 checks passed
@Piotrk39 Piotrk39 deleted the feat.remove-user-from-team branch September 10, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aberonni aberonni aberonni approved these changes

Assignees
No one assigned
Labels
portalicious Changes related to the portalicious release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piotrk39 @aberonni