portalicious: personal-information page AB#29985 #5827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interfaces/Portalicious/src/app/components/form/form-default.component.html
Outdated
Show resolved
Hide resolved
elwinschmitz
force-pushed
the
arsforza/portalicious.profile-personal-information
branch
from
b96c077
to
5913ad6
Compare
elwinschmitz
force-pushed
the
arsforza/portalicious.profile-personal-information
branch
from
5913ad6
to
0bdc283
Compare
elwinschmitz
force-pushed
the
arsforza/portalicious.profile-personal-information
branch
from
0bdc283
to
461e459
Compare
elwinschmitz
force-pushed
the
arsforza/portalicious.profile-personal-information
branch
from
6fc2eb8
to
c10d5fc
Compare
aberonni
reviewed
Sep 24, 2024
There was a problem hiding this comment.
@elwinschmitz I wanted to give you an update after my chat with Ruben and figured it would be easier to do it close to the code and I ended up doing a review while I was at it :D
interfaces/Portalicious/src/app/components/form/form-default.component.html
Outdated
Show resolved
Hide resolved
...licious/src/app/domains/financial-service-provider/financial-service-provider.api.service.ts
Show resolved
Hide resolved
interfaces/Portalicious/src/app/domains/project/project.api.service.ts
Outdated
Show resolved
Hide resolved
interfaces/Portalicious/src/app/domains/project/project.api.service.ts
Outdated
Show resolved
Hide resolved
interfaces/Portalicious/src/app/domains/project/project.helper.ts
Outdated
Show resolved
Hide resolved
.../project-registration-personal-information/project-registration-personal-information.page.ts
Show resolved
Hide resolved
...licious/src/app/domains/financial-service-provider/financial-service-provider.api.service.ts
Show resolved
Hide resolved
elwinschmitz
force-pushed
the
arsforza/portalicious.profile-personal-information
branch
from
7bac74d
to
020f928
Compare
elwinschmitz
force-pushed
the
arsforza/portalicious.profile-personal-information
branch
from
1041890
to
6726b06
Compare
elwinschmitz
force-pushed
the
arsforza/portalicious.profile-personal-information
branch
from
1b54717
to
c50dadc
Compare
elwinschmitz
approved these changes
Sep 25, 2024
AB#30486 This addresses the oddity encountered with attribute labels
…rvice.ts Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
elwinschmitz
force-pushed
the
arsforza/portalicious.profile-personal-information
branch
from
c50dadc
to
a523aba
Compare
elwinschmitz
deleted the
arsforza/portalicious.profile-personal-information
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#29985
Describe your changes
Checklist before requesting a review