refactor note endpoint(s)

interfaces/Portal/src/app/services/programs-service-api.service.ts

@@ -235,9 +235,8 @@ export class ProgramsServiceApiService {
   ): Promise<Note> {
     return this.apiService.post(
       environment.url_121_service_api,
-      `/programs/${programId}/notes`,
+      `/programs/${programId}/registrations/${referenceId}/note`,
       {
-        referenceId,
         text: note,
       },
     );
@@ -246,7 +245,7 @@ export class ProgramsServiceApiService {
   getNotes(programId: number, referenceId: string): Promise<Note[]> {
     return this.apiService.get(
       environment.url_121_service_api,
-      `/programs/${programId}/notes/${referenceId}`,
+      `/programs/${programId}/registrations/${referenceId}/notes`,
       null,
       false,
     );

interfaces/Portalicious/src/app/domains/project/project.api.service.ts

@@ -136,9 +136,8 @@ export class ProjectApiService extends DomainApiService {
   }): Promise<unknown> {
     return this.httpWrapperService.perform121ServiceRequest<Project>({
       method: 'POST',
-      endpoint: `${BASE_ENDPOINT}/${projectId().toString()}/notes`,
+      endpoint: `${BASE_ENDPOINT}/${projectId().toString()}/registrations/${registrationReferenceId()}/note`,
       body: {
-        referenceId: registrationReferenceId(),
         text: note,
       },
     });

services/121-service/src/notes/dto/note.dto.ts

@@ -1,10 +1,7 @@
 import { ApiProperty } from '@nestjs/swagger';
-import { IsString, Length } from 'class-validator';
+import { IsString } from 'class-validator';
 
 export class CreateNoteDto {
-  @ApiProperty({ example: '910c50be-f131-4b53-b06b-6506a40a2734' })
-  @Length(5, 200)
-  public readonly referenceId: string;
   @ApiProperty({ example: 'note here' })
   @IsString()
   public readonly text: string;

services/121-service/src/notes/notes.controller.ts

@@ -46,15 +46,17 @@ export class NoteController {
       'ReferenceId is not known - NOTE: this endpoint is scoped, depending on program configuration it only returns/modifies data the logged in user has access to.',
   })
   @ApiParam({ name: 'programId', required: true, type: 'integer' })
-  @Post(':programId/notes')
+  @ApiParam({ name: 'referenceId', required: true, type: 'string' })
+  @Post(':programId/registrations/:referenceId/note')
   public async createNote(
     @Req() req,
     @Param('programId', ParseIntPipe) programId: number,
+    @Param('referenceId') referenceId: string,
     @Body() createNote: CreateNoteDto,
   ): Promise<void> {
     const userId = req.user.id;
     await this.noteService.createNote(
-      createNote.referenceId,
+      referenceId,
       createNote.text,
       userId,
       programId,
@@ -70,13 +72,12 @@ export class NoteController {
     type: [ResponseNoteDto],
   })
   @ApiParam({ name: 'programId', required: true, type: 'integer' })
-  @ApiParam({ name: 'referenceId', required: true })
-  @Get(':programId/notes/:referenceId')
+  @ApiParam({ name: 'referenceId', required: true, type: 'string' })
+  @Get(':programId/registrations/:referenceId/notes')
   public async retrieveNotes(
-    @Param() params,
-    @Param('programId', ParseIntPipe)
-    programId: number,
+    @Param('programId', ParseIntPipe) programId: number,
+    @Param('referenceId') referenceId: string,
   ): Promise<ResponseNoteDto[]> {
-    return await this.noteService.retrieveNotes(params.referenceId, programId);
+    return await this.noteService.retrieveNotes(referenceId, programId);
   }
 }

services/121-service/test/helpers/program.helper.ts

@@ -467,9 +467,9 @@ export async function postNote(
   accessToken: string,
 ): Promise<request.Response> {
   return await getServer()
-    .post(`/programs/${programId}/notes`)
+    .post(`/programs/${programId}/registrations/${referenceId}/note`)
     .set('Cookie', [accessToken])
-    .send({ referenceId, text });
+    .send({ text });
 }
 
 export async function getNotes(
@@ -478,7 +478,7 @@ export async function getNotes(
   accessToken: string,
 ): Promise<request.Response> {
   return await getServer()
-    .get(`/programs/${programId}/notes/${referenceId}`)
+    .get(`/programs/${programId}/registrations/${referenceId}/notes`)
     .set('Cookie', [accessToken]);
 }