Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows specific startup cmd AB#30396 #5837

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: windows specific startup cmd AB#30396 #5837

merged 2 commits into from
Sep 19, 2024

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Sep 18, 2024 •
edited
Loading

AB#30396

Describe your changes

Replace window-user specific start-up command by generic via env-variable.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@elwinschmitz elwinschmitz added the chore Something that does not affect the end user label Sep 19, 2024
@Vladimir-Petkov Vladimir-Petkov enabled auto-merge (squash) September 19, 2024 08:49
@Vladimir-Petkov Vladimir-Petkov merged commit 81bd2e3 into main Sep 19, 2024
6 checks passed
@Vladimir-Petkov Vladimir-Petkov deleted the fix.121-service-windows-startup branch September 19, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elwinschmitz elwinschmitz elwinschmitz approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jannisvisser @elwinschmitz @Vladimir-Petkov