Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notes endpoints small refactors and refactor comments #5847

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Notes endpoints small refactors and refactor comments #5847

merged 3 commits into from
Sep 25, 2024

Conversation

diderikvw
Copy link
Contributor

@diderikvw diderikvw commented Sep 23, 2024 •
edited
Loading

AB#30463

Describe your changes

After the refactor moving the /notes endpoint, a few additional "cleanliness" refactors while we are at it.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@diderikvw diderikvw added the chore Something that does not affect the end user label Sep 23, 2024
@diderikvw diderikvw enabled auto-merge (squash) September 25, 2024 07:38
@diderikvw diderikvw merged commit 8c29625 into main Sep 25, 2024
12 checks passed
@diderikvw diderikvw deleted the diderikvw/notes-endpoint-refactor-refactors branch September 25, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tijsziere tijsziere tijsziere approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diderikvw @tijsziere