Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fail PRs with XXX comments #5864

Merged
merged 2 commits into from
Sep 30, 2024
Merged

chore: fail PRs with XXX comments #5864

merged 2 commits into from
Sep 30, 2024

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Sep 27, 2024 •
edited
Loading

AB#30490

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@aberonni aberonni added the chore Something that does not affect the end user label Sep 27, 2024
@aberonni aberonni force-pushed the aberonni/xxx-comments branch 6 times, most recently from 3f4c9be to 94b1bc7 Compare September 27, 2024 10:26
@aberonni aberonni marked this pull request as ready for review September 27, 2024 10:47
@elwinschmitz elwinschmitz enabled auto-merge (squash) September 30, 2024 08:27
@elwinschmitz elwinschmitz merged commit a980980 into main Sep 30, 2024
11 checks passed
@elwinschmitz elwinschmitz deleted the aberonni/xxx-comments branch September 30, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elwinschmitz elwinschmitz elwinschmitz approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aberonni @elwinschmitz