Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portalicious: add/edit user form AB#30597 AB#30598 #5902

Merged
merged 8 commits into from
Oct 11, 2024
Merged

portalicious: add/edit user form AB#30597 AB#30598 #5902

merged 8 commits into from
Oct 11, 2024

Conversation

arsforza
Copy link
Contributor

@arsforza arsforza commented Oct 4, 2024 •
edited
Loading

AB#30597 AB#30598

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@aberonni aberonni marked this pull request as draft October 8, 2024 08:26
@aberonni aberonni added the portalicious [DEPRECATED] Changes related to the Portalicious release label Oct 8, 2024
@arsforza arsforza force-pushed the arsforza/portalicious.add-user-form branch from fa41868 to f95936e Compare October 9, 2024 15:23
@arsforza arsforza marked this pull request as ready for review October 9, 2024 16:42
@arsforza arsforza requested a review from aberonni October 9, 2024 16:43
aberonni
aberonni requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm very happy that all the changes I'm requesting are just details :)

interfaces/Portalicious/src/app/pages/users/add-user-form/add-user-form.component.ts Outdated Show resolved Hide resolved
interfaces/Portalicious/src/app/pages/users/add-user-form/add-user-form.component.ts Outdated Show resolved Hide resolved
interfaces/Portalicious/src/app/pages/users/users.page.html Show resolved Hide resolved
interfaces/Portalicious/src/app/pages/users/add-user-form/add-user-form.component.ts Outdated Show resolved Hide resolved
interfaces/Portalicious/src/app/domains/user/user.api.service.ts Show resolved Hide resolved
@arsforza arsforza requested a review from aberonni October 11, 2024 10:22
@arsforza arsforza force-pushed the arsforza/portalicious.add-user-form branch from 92f9dce to 88794d9 Compare October 11, 2024 13:43
@arsforza arsforza force-pushed the arsforza/portalicious.add-user-form branch from 2f9dafd to b856020 Compare October 11, 2024 13:56
@arsforza arsforza requested a review from aberonni October 11, 2024 13:56
aberonni
aberonni approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@aberonni aberonni merged commit a721703 into main Oct 11, 2024
5 checks passed
@aberonni aberonni deleted the arsforza/portalicious.add-user-form branch October 11, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aberonni aberonni aberonni approved these changes

Assignees
No one assigned
Labels
portalicious [DEPRECATED] Changes related to the Portalicious release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arsforza @aberonni