Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: api test for referenceId as number #5915

Merged
merged 2 commits into from
Oct 11, 2024
Merged

test: api test for referenceId as number #5915

merged 2 commits into from
Oct 11, 2024

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Oct 11, 2024 •
edited
Loading

AB#30721

Describe your changes

API-test that would have caught the bug this item is based on.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@jannisvisser jannisvisser added the chore Something that does not affect the end user label Oct 11, 2024
aberonni
aberonni previously approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you whether you feel the need to / want to add the other cases

services/121-service/test/registrations/pagination/filter-registration.test.ts Show resolved Hide resolved
@jannisvisser jannisvisser merged commit 1746de5 into main Oct 11, 2024
3 checks passed
@jannisvisser jannisvisser deleted the test.api-test-referenceId-as-number branch October 11, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aberonni aberonni aberonni approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jannisvisser @aberonni