Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portalicious: add onDestroy -> unsubscribe to avoid memory leak #5998

Merged
merged 1 commit into from
Oct 30, 2024
Merged

portalicious: add onDestroy -> unsubscribe to avoid memory leak #5998

merged 1 commit into from
Oct 30, 2024

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Oct 29, 2024 •
edited
Loading

AB#31008

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@aberonni aberonni added the portalicious Changes related to the portalicious release label Oct 29, 2024
@aberonni aberonni enabled auto-merge (squash) October 29, 2024 13:31
@aberonni aberonni force-pushed the aberonni/portalicious-on-destroy branch from 956bd72 to 1bfbafe Compare October 30, 2024 08:40
@aberonni aberonni force-pushed the aberonni/portalicious-on-destroy branch from 1bfbafe to 372d55d Compare October 30, 2024 09:11
@aberonni aberonni merged commit 400dcd1 into main Oct 30, 2024
5 checks passed
@aberonni aberonni deleted the aberonni/portalicious-on-destroy branch October 30, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSmallenbroek PeterSmallenbroek PeterSmallenbroek approved these changes

Assignees
No one assigned
Labels
portalicious Changes related to the portalicious release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aberonni @PeterSmallenbroek