Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for selection behaviour #6048

Merged
merged 8 commits into from
Nov 8, 2024
Merged

Add test cases for selection behaviour #6048

merged 8 commits into from
Nov 8, 2024

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Nov 8, 2024 •
edited
Loading

AB#31181

Describe your changes

Adds E2E tests of the count of selected PAs for the bulk action.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Piotrk39 Piotrk39 added chore Something that does not affect the end user portalicious Changes related to the portalicious release labels Nov 8, 2024
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-test-for-right-click-selection-on-registrations branch from 9667c19 to aa7d17b Compare November 8, 2024 11:29
@Piotrk39 Piotrk39 marked this pull request as ready for review November 8, 2024 12:11
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-test-for-right-click-selection-on-registrations branch from aa7d17b to 7742e0a Compare November 8, 2024 12:11
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-test-for-right-click-selection-on-registrations branch from 7742e0a to c919342 Compare November 8, 2024 14:05
aberonni
aberonni requested changes Nov 8, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
e2e/portalicious/pages/RegistrationsPage.ts Outdated Show resolved Hide resolved
Piotrk39 and others added 7 commits November 8, 2024 15:33
@Piotrk39
Add test for validating one registration selected
2c6fc51
@Piotrk39
Add test for multiplie selection count
08793a0
@Piotrk39 @aberonni
Update .vscode/settings.json
1114f82 
Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
@Piotrk39 @aberonni
Update e2e/portalicious/pages/RegistrationsPage.ts
1ce2915 
Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
@Piotrk39 @aberonni
Update e2e/portalicious/pages/RegistrationsPage.ts
b0f808b 
Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
@Piotrk39 @aberonni
Update e2e/portalicious/pages/RegistrationsPage.ts
35f03ff 
Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
@Piotrk39
Add changes from PR review
788220b
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-test-for-right-click-selection-on-registrations branch from 627f094 to 788220b Compare November 8, 2024 14:33
@Piotrk39 Piotrk39 enabled auto-merge (squash) November 8, 2024 14:38
@Piotrk39 Piotrk39 merged commit 5a87a35 into main Nov 8, 2024
5 checks passed
@Piotrk39 Piotrk39 deleted the feat.add-e2e-test-for-right-click-selection-on-registrations branch November 8, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aberonni aberonni aberonni approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user portalicious Changes related to the portalicious release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piotrk39 @aberonni