Add cherry picked test and dependencies #6374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Piotrk39
added
chore
aberonni
previously requested changes
Jan 9, 2025
e2e/portalicious/tests/ViewPayment/GraphDisplaysAllCorrectPaymentStatuses.spec.ts
Outdated
Show resolved
Hide resolved
Piotrk39
force-pushed
the
feat.add-e2e-test-for-graph-in-view-payment
branch
from
5bc892f to
d61aaf3
Compare
Piotrk39
force-pushed
the
feat.add-e2e-test-for-graph-in-view-payment
branch
from
3716cb3 to
55d18be
Compare
|
@arsforza Looks good to me. I moved only the fixed await inside the assertion and reduced it to 1 second after the chip is hidden. |
arsforza
approved these changes
Jan 24, 2025
* fix: refetch based on PaymentAggregate count * fix: rm page reload form test * fix: add await to test * fix: change expected amount
Piotrk39
force-pushed
the
feat.add-e2e-test-for-graph-in-view-payment
branch
from
aa46a40 to
9681462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#32422
Describe your changes
Adds test for checking correct display of payment statuses in the "Transfers data" graph.
Checklist before requesting a review
Portalicious preview deployment
https://lively-river-04adce503-6374.westeurope.5.azurestaticapps.net