-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adtl-qc: Quality Control module with report generation #89
Draft
abhidg
wants to merge
19
commits into
main
Choose a base branch
from
qc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhidg
commented
Oct 17, 2023
- qc: add adtl-qc subcommand, bump version
- docs: add quality control module documentation
- qc: new module for data quality control
- qc: add support for rule collection
- qc: process work units, move to submodule
- qc: add tests
- qc: save results in SQLite DB
- qc: add templates
- qc: add long desc, write rules to DB
- qc: style fixups
- qc: add report module
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
===========================================
- Coverage 100.00% 90.53% -9.47%
===========================================
Files 2 5 +3
Lines 677 909 +232
===========================================
+ Hits 677 823 +146
- Misses 0 86 +86
|
The `reason` attribute can hold metadata about the reason a rule was triggered. This can be used to add row-dependent descriptive information as well as being used by the schema functions to fill in the reason why a particular row failed schema validation.
Schema rules validate dataframes against a JSON Schema
Do not save to DB as data is corrupted on insert
pd.read_csv() does not do automatic type conversions for mixed types. This adds a _to_json() helper function that converts a row into JSON, auto-converting floating point, integer and boolean points and dropping keys with null values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.