Skip to content

Commit

Permalink
parsing: Default to has_stable_ids = True
Browse files Browse the repository at this point in the history
While the correct behaviour is to have stable ids False since that
is the case for the majority of the sources, setting this to True
temporarily before #1954 is fixed. Handling sources without stable
ids automatically requires new curator API endpoints which haven't
been merged to -stable yet.
  • Loading branch information
abhidg committed Jun 18, 2021
1 parent 36cabc3 commit bc8222c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ingestion/functions/common/parsing_lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,9 @@ def run(
api_creds, cookies)
source_info = source_info_request.json()
# treat absence of evidence as meaning the source _does not_ have stable IDs, as that's more likely
has_stable_ids = source_info.get('hasStableIdentifiers', False)
# ^^ correct behaviour, but switching to True before #1954
# is fixed, as new curator API endpoints are not in -stable.
has_stable_ids = source_info.get('hasStableIdentifiers', True)
try:
fd, local_data_file_name = tempfile.mkstemp()
local_data_file = os.fdopen(fd, "wb")
Expand Down

0 comments on commit bc8222c

Please sign in to comment.