Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not clear when a parser had 0 new cases to deal with. #1355

Closed
iamleeg opened this issue Nov 17, 2020 · 1 comment
Closed

Not clear when a parser had 0 new cases to deal with. #1355

iamleeg opened this issue Nov 17, 2020 · 1 comment
Assignees
@iamleeg
Labels
P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix
Milestone
Strongcat

Comments

@iamleeg
Copy link
Contributor

iamleeg commented Nov 17, 2020

Describe the bug

A couple of times I've been asked what's wrong with a parser not adding new cases and not reporting an error, when the situation is that the source data did not contain any cases matching the date filter criteria. I don't necessarily see information about those in the uploads dashboard (for example, the Colombia parser last ran on 16th November, "successfully" uploaded 0 records, but I don't see that in the dashboard); I have to go through the AWS logs to find this information out.
@iamleeg iamleeg mentioned this issue Nov 17, 2020
Merged
@calremmel calremmel added this to the Post Launch milestone Mar 2, 2021
@calremmel calremmel added the P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix label Mar 2, 2021
@abhidg abhidg removed this from the Post Launch (Zoe) milestone Apr 20, 2021
@abhidg abhidg added this to the Strongcat milestone Jun 15, 2021
@iamleeg iamleeg self-assigned this Jun 28, 2021
@iamleeg
Copy link
Contributor Author

iamleeg commented Jun 28, 2021

OK these are actually filtered out of the UI but are present in the back end, so a simple matter of not requesting the filter.

iamleeg added a commit that referenced this issue Jun 28, 2021
@iamleeg
Do not filter the list of uploads to exclude zero-case uploads.
ee39af7 
#1355 it is confusing to lose track of an upload because it made no changes

when those are the ones we are most likely to want to diagnose
@iamleeg iamleeg mentioned this issue Jun 28, 2021
Merged
abhidg pushed a commit that referenced this issue Jul 2, 2021
@iamleeg @abhidg
Do not filter the list of uploads to exclude zero-case uploads.
1dad437 
#1355 it is confusing to lose track of an upload because it made no changes

when those are the ones we are most likely to want to diagnose
abhidg pushed a commit that referenced this issue Jul 2, 2021
@iamleeg @abhidg
Do not filter the list of uploads to exclude zero-case uploads.
197eb44 
#1355 it is confusing to lose track of an upload because it made no changes

when those are the ones we are most likely to want to diagnose
@abhidg abhidg closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamleeg iamleeg

Labels
P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix
Projects
None yet
Milestone
Strongcat
Development

No branches or pull requests
3 participants
@abhidg @iamleeg @calremmel