Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the version number somewhere #2289

Closed
iamleeg opened this issue Dec 3, 2021 · 1 comment
Closed

Display the version number somewhere #2289

iamleeg opened this issue Dec 3, 2021 · 1 comment
Assignees
Labels
good first issue P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix
Milestone

Comments

@iamleeg
Copy link
Contributor

iamleeg commented Dec 3, 2021

Is your feature request related to a problem? Please describe.
A few hours of debugging recently could have been prevented if it'd been obvious that a Kubernetes configuration change to deploy a new version of g.h hadn't stuck and the old version was still live in production.

Describe the solution you'd like
The version number should be shown on the UI. Ideally this would be the commit sha in dev, and the git tag in prod.

Describe alternatives you've considered
Spending hours debugging.

@abhidg abhidg added the P2: Nice to have This would be nice to have, if we have time we will fix it, if not good to launch and fix later when label Dec 10, 2021
@abhidg abhidg added this to the Lewis milestone Dec 15, 2021
@iamleeg iamleeg added P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix and removed P2: Nice to have This would be nice to have, if we have time we will fix it, if not good to launch and fix later when labels Dec 15, 2021
@iamleeg
Copy link
Contributor Author

iamleeg commented Jan 4, 2022

My notes from last year:

First tried using react-git-info but because the .git folder is at the top level it isn't available in the Docker image for the UI build. What can I do about that? I need to run the git command in the Dockerfile, but make sure it works in both k8s and docker-compose. And I need it to also work for local dev where you might not be using docker. Hmm, seems unlikely. Can do as an arg to the Dockerfile but would then require people to use Docker for all dev, including running unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix
Projects
None yet
Development

No branches or pull requests

3 participants