Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply canonical list of ISO 3166-1 country codes used #2559

Closed
iamleeg opened this issue Feb 28, 2022 · 5 comments
Closed

Supply canonical list of ISO 3166-1 country codes used #2559

iamleeg opened this issue Feb 28, 2022 · 5 comments
Assignees
@abhidg @iamleeg
Labels
API Documentation Bug relates to documentation which needs updating or revieiwng ISO3166 Relating to transition to ISO 3166 two letter country codes P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix
Milestone
1.12 Oberon

Comments

@iamleeg
Copy link
Contributor

iamleeg commented Feb 28, 2022

[8:06 AM] Lol. Well my next suggestion was going to be to supply a list of available country codes 🙂

Currently we have a lot of different sources: a JS library, a Python library, and some workarounds for country names that Mapbox uses that neither of those recognise. Would be good to build a list of the country codes we use with maps to the name. Best would be to do this in Python and R as part of our API libraries.
@iamleeg iamleeg added Documentation Bug relates to documentation which needs updating or revieiwng API ISO3166 Relating to transition to ISO 3166 two letter country codes labels Feb 28, 2022
@iamleeg iamleeg added this to the Koa milestone Feb 28, 2022
@joe-brilliant joe-brilliant added the P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix label Feb 28, 2022
@abhidg
Copy link
Contributor

abhidg commented Feb 28, 2022

The current documentation links to the Wikipedia entry on ISO 3166 codes which has a comprehensive list.

@joe-brilliant
Copy link

I think we can closer this @iamleeg @abhidg ?

@iamleeg
Copy link
Contributor Author

iamleeg commented Mar 11, 2022

No, the wikipedia list is not sufficient.

Would be good to build a list of the country codes we use with maps to the name.

This won't include all of the weird workarounds we have for Mapbox (e.g. it uses "United States" for country US, which most libraries don't use because it's ambiguous with "United States Minor Outlying Islands" when you're searching), and the names otherwise might not be the same as the ones we use. We actually have to prepare a list of the country codes we use and map them to the names of the countries we use.

@joe-brilliant
Copy link

Duly noted; thanks for the clarification + explanation @iamleeg !

iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Look up the distinct country codes used in the database #2559
97d1656
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
#2559 return map of code to country names
d7d090c
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Replace iso-3166 with i18n-iso-countries #2559
e15c5f7
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Add a geocoding endpoint to find the names iso3166 uses for a country #…
2a5d1e9 
…2559
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Incorporate names from the geocoding service into the list of responses
0452d5f 
#2559
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Add the test I should have already added #2559
4c7e1ed
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Add test for curator API #2559
e4aa946
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Look up the distinct country codes used in the database #2559
c9d8688
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
#2559 return map of code to country names
4e66dc4
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Replace iso-3166 with i18n-iso-countries #2559
632ab41
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Add a geocoding endpoint to find the names iso3166 uses for a country #…
c5e1332 
…2559
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Incorporate names from the geocoding service into the list of responses
f4d10b2 
#2559
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Add the test I should have already added #2559
8fee379
iamleeg added a commit that referenced this issue Mar 14, 2022
@iamleeg
Add test for curator API #2559
d096007
iamleeg added a commit that referenced this issue Mar 15, 2022
@iamleeg
New index to enable distinct country searching AT SCALE #2559
aff5275
iamleeg added a commit that referenced this issue Mar 15, 2022
@iamleeg
New index to enable distinct country searching AT SCALE #2559
78832bb
iamleeg added a commit that referenced this issue Mar 17, 2022
@iamleeg
Script to fetch country codes #2559
781db6a 
Would work, if not for the mongo perf issues
iamleeg added a commit that referenced this issue Mar 17, 2022
@iamleeg
Switch to mongo 5 for local/CI testing #2559
1eb1cca
iamleeg added a commit that referenced this issue Mar 17, 2022
@iamleeg
Revert "Switch to mongo 5 for local/CI testing #2559"
c75c8ce 
This reverts commit 1eb1cca.
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Add the correct collation to the country names search query #2559
e360284
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Update mongodb version and fix type errors #2559
1f44ac1
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Resolve incompatibilities and then address types changes motivated by…
d35eb3a 
… updates #2559

Also add general request and error logging at the top level
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Update @types/node to v16 to deal with build breaks in Docker #2559
97a5ca0
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Change node and @types/node version so mongo will build #2559
6c38e7d 
This puts us onto the current LTS release of node in curator-service.

An alternative was to update to mongo 4.3+ but that meant updating typescript too
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Extract database connection to a function in the model/database module …
eba2789 
…#2559
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Remove mongoose from the index file #2559
60fb1bc
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
mongoose not used in database connection #2559
9356f05
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
mongoose not used at all #2559
23447aa
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Server start is now async #2559
0de34a7
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Do not create the app on importing index.ts #2559
02f679c
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Kill mongoose with fire #2559
0b09099
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Remove mongoose package #2559
ab00cf4
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Add the correct collation to the country names search query #2559
1331622
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Update mongodb version and fix type errors #2559
f1266df
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Resolve incompatibilities and then address types changes motivated by…
97a305e 
… updates #2559

Also add general request and error logging at the top level
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Update @types/node to v16 to deal with build breaks in Docker #2559
d5520e9
iamleeg added a commit that referenced this issue Apr 19, 2022
@iamleeg
Change node and @types/node version so mongo will build #2559
ffe5ca9 
This puts us onto the current LTS release of node in curator-service.

An alternative was to update to mongo 4.3+ but that meant updating typescript too
@joe-brilliant joe-brilliant modified the milestones: Devi, Agnes Apr 29, 2022
iamleeg added a commit that referenced this issue May 26, 2022
@iamleeg
Add a script to fetch the list of countries #2559
0849e55
iamleeg added a commit that referenced this issue May 26, 2022
@iamleeg
Add a script to fetch the list of countries #2559
437f4b0
iamleeg added a commit that referenced this issue May 30, 2022
@iamleeg
Add country codes maps to the data dictionaries #2559
3131166
iamleeg added a commit that referenced this issue May 30, 2022
@iamleeg
Add curl to the dockerfile for data export #2559
8c26f9f
iamleeg added a commit that referenced this issue May 31, 2022
@iamleeg
Add country codes maps to the data dictionaries #2559
35b5482
iamleeg added a commit that referenced this issue May 31, 2022
@iamleeg
Add curl to the dockerfile for data export #2559
72f906f
@joe-brilliant joe-brilliant modified the milestones: Agnes, Oberon Jun 7, 2022
@joe-brilliant
Copy link

@abhidg please close if this has been deployed

@abhidg abhidg closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhidg abhidg

@iamleeg iamleeg

Labels
API Documentation Bug relates to documentation which needs updating or revieiwng ISO3166 Relating to transition to ISO 3166 two letter country codes P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix
Projects
None yet
Milestone
1.12 Oberon
Development

No branches or pull requests
3 participants
@abhidg @iamleeg @joe-brilliant