Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bucket ages #2670

Closed
iamleeg opened this issue Apr 19, 2022 · 0 comments · Fixed by #2706
Closed

Bucket ages #2670

iamleeg opened this issue Apr 19, 2022 · 0 comments · Fixed by #2706
Assignees
@iamleeg @maciej-zarzeczny @Ania661
Labels
DPIA P0: Critical path blocker Blocking testing or the launch critical path, drop everything to investigate & fix
Milestone
Agnes

Comments

@iamleeg
Copy link
Contributor

iamleeg commented Apr 19, 2022

This was feedback from the DPIA: ages should be bucketed into 0-1 and then five-year ranges (i.e. 1-6, 6-11 etc). I suppose that means for exact ages they should be converted into buckets, and for existing ranges they should be widened to ensure that they are at least five years.
@iamleeg iamleeg added the DPIA label Apr 19, 2022
@joe-brilliant joe-brilliant added this to the Devi milestone Apr 19, 2022
@joe-brilliant joe-brilliant added the P0: Critical path blocker Blocking testing or the launch critical path, drop everything to investigate & fix label Apr 19, 2022
iamleeg added a commit that referenced this issue Apr 20, 2022
@iamleeg
Migration to add age bucketing field to cases schema #2670
56baa76
iamleeg added a commit that referenced this issue Apr 20, 2022
@iamleeg
Add the ageBuckets reference to mongoose schema #2670
573e256
iamleeg added a commit that referenced this issue Apr 20, 2022
@iamleeg
Add pres-ave hook to populate case age buckets from age range #2670
ef87a6f
iamleeg added a commit that referenced this issue Apr 20, 2022
@iamleeg
Revert "Add pres-ave hook to populate case age buckets from age range #…
59d963f 
…2670"

I can't use the mongoose hooks to migrate the age buckets over, as they won't run correctly in model tests.

This reverts commit ef87a6f.
iamleeg added a commit that referenced this issue Apr 21, 2022
@iamleeg
Convert age range to age buckets on case creation #2670
9b98106
iamleeg added a commit that referenced this issue Apr 21, 2022
@iamleeg
Compute the age range from the buckets when returning a case #2670
59b166c
iamleeg added a commit that referenced this issue Apr 21, 2022
@iamleeg
Compute the age range from the buckets when returning a case #2670
68eb088
iamleeg added a commit that referenced this issue Apr 22, 2022
@iamleeg
Bucket ages on put #2670
fefa7b2
iamleeg added a commit that referenced this issue Apr 22, 2022
@iamleeg
Add an explicit test for the GET case #2670
be6e122
iamleeg added a commit that referenced this issue Apr 22, 2022
@iamleeg
Bucket age ranges in cases list #2670
864b0cd
iamleeg added a commit that referenced this issue Apr 22, 2022
@iamleeg
no need to leak the AgeBucket object IDs out in API responses #2670
f7edeb4
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Set age buckets on batchUpsert #2670
42aae47
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Update age buckets in batchUpdate #2670
e0ad9de
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Bucket ages in case upsert #2670
4055df0
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Bucket ages on case download #2670
aee42fd
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Describe age buckets in data-service README #2670
993bbc6
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Migration to add age bucketing field to cases schema #2670
85b4409
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Add the ageBuckets reference to mongoose schema #2670
18cf869
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Add pres-ave hook to populate case age buckets from age range #2670
27439ff
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Revert "Add pres-ave hook to populate case age buckets from age range #…
8075002 
…2670"

I can't use the mongoose hooks to migrate the age buckets over, as they won't run correctly in model tests.

This reverts commit ef87a6f.
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Convert age range to age buckets on case creation #2670
4a27ee0
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Compute the age range from the buckets when returning a case #2670
1e4bf13
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Bucket ages on put #2670
441b47f
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Add an explicit test for the GET case #2670
b38eafc
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
Bucket age ranges in cases list #2670
8a2165d
iamleeg added a commit that referenced this issue Apr 25, 2022
@iamleeg
no need to leak the AgeBucket object IDs out in API responses #2670
fabbbf5
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Replace mongoimport for importing sample cases with API-based import #…
6a0b309 
…2670
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Supply connection name to mongoose that matches collection created in…
155a3d8 
… migration #2670
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Correct the implementation of the drop-cases script #2670
340128e
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Generate and return an API key when a test user is generated #2670
b7fa16a
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Import script can create a user if no API key given #2670
4dc7fb1
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Remove unnecessary env vars from npm invocation #2670
b722cf1
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Capture and report errors in API connections #2670
fa025ce
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Fix test failure in case search #2670
3e59b7f
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Add missing name for CN to the geocoder workarounds list #2670
a44387c
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Remove test knowledge of case age UI for now #2670
a775dd1
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Widen age range expectations in bulk case upload tests #2670
18a7aa9
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Age entry automatically buckets ages; explain that in tool tip #2670
9b261e1
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Write a test to ensure identical cases in batchUpsert are ignored #2670
c7ec23c
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Fix case downloads #2670
6cc1b50
iamleeg added a commit that referenced this issue May 5, 2022
@iamleeg
Change expectation of case revisions on upsert #2670
985e8f4
iamleeg added a commit that referenced this issue May 6, 2022
@iamleeg
Remove age range from mongoose types; fix model tests #2670
4ec7356 
Controller tests still fail at this point.
iamleeg added a commit that referenced this issue May 6, 2022
@iamleeg
Fix validation of age in cases controller #2670
663e37c
iamleeg added a commit that referenced this issue May 6, 2022
@iamleeg
Migration to remove expectation of demographics.ageRange #2670
398a593
iamleeg added a commit that referenced this issue May 9, 2022
@iamleeg
Update expected error message in cypress test #2670
e78a871
iamleeg added a commit that referenced this issue May 9, 2022
@iamleeg
Remove age range from mongoose types; fix model tests #2670
7a38684 
Controller tests still fail at this point.
iamleeg added a commit that referenced this issue May 9, 2022
@iamleeg
Fix validation of age in cases controller #2670
e04ae63
iamleeg added a commit that referenced this issue May 9, 2022
@iamleeg
Migration to remove expectation of demographics.ageRange #2670
eb3aec1
iamleeg added a commit that referenced this issue May 9, 2022
@iamleeg
Update expected error message in cypress test #2670
e863141
@joe-brilliant joe-brilliant mentioned this issue May 10, 2022
Open
iamleeg added a commit that referenced this issue May 23, 2022
@iamleeg
#2670 script to delete unused age range data
f864626
@iamleeg iamleeg mentioned this issue May 23, 2022
Merged
iamleeg added a commit that referenced this issue May 23, 2022
@iamleeg
#2670 script to delete unused age range data
71a7be2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamleeg iamleeg

@maciej-zarzeczny maciej-zarzeczny

@Ania661 Ania661

Labels
DPIA P0: Critical path blocker Blocking testing or the launch critical path, drop everything to investigate & fix
Projects
None yet
Milestone
Agnes
Development

Successfully merging a pull request may close this issue.

#2670 script to delete unused age range data globaldothealth/list
4 participants
@iamleeg @maciej-zarzeczny @joe-brilliant @Ania661