1608 download filtered results UI modal #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 5, 2021 15:21
…608-download-filtered-results-ui-modal
…608-download-filtered-results-ui-modal
Codecov Report
@@ Coverage Diff @@
## main #1625 +/- ##
===========================================
+ Coverage 55.99% 82.80% +26.80%
===========================================
Files 69 57 -12
Lines 2343 1803 -540
Branches 724 339 -385
===========================================
+ Hits 1312 1493 +181
+ Misses 1031 310 -721
Continue to review full report at Codecov.
|
…608-download-filtered-results-ui-modal
added 11 commits
May 17, 2021 12:05
…608-download-filtered-results-ui-modal
…608-download-filtered-results-ui-modal
…608-download-filtered-results-ui-modal
…hub.com/globaldothealth/list into 1608-download-filtered-results-ui-modal
This reverts commit 1d92064.
This reverts commit f9d43ec.
added 5 commits
June 1, 2021 12:11
iamleeg
reviewed
Jun 3, 2021
Comment on lines
+77
to
+80
| if (req.body.query && req.body.caseIds) { | ||
| res.status(400).json({ message: 'Bad request' }); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Nice, good to test this constraint before continuing
iamleeg
reviewed
Jun 3, 2021
Comment on lines
117
to
131
| if (queryLimit) { | ||
| matchingCases = await Case.aggregate(casesIgnoringExcluded) | ||
| .collation({ | ||
| locale: 'en_US', | ||
| strength: 2, | ||
| }) | ||
| .limit(queryLimit); | ||
| } else { | ||
| matchingCases = await Case.aggregate( | ||
| casesIgnoringExcluded, | ||
| ).collation({ | ||
| locale: 'en_US', | ||
| strength: 2, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Not a big deal, but could be changed to:
let query:any = Case.aggregate(casesIgnoringExcluded)collation({locale: 'en_US', strength: 2, });
if (queryLimit) { query = query.limit(queryLimit); }
const matchingCases = await query;
There was a problem hiding this comment.
Yeah, the code will be cleaner, thank you for spotting that!
iamleeg
reviewed
Jun 3, 2021
Comment on lines
+102
to
+104
| <p>Please visit the link below to download list of cases in response to your query <strong>${workerData.query}</strong>.</p> | ||
|
|
||
| <a href="${signedUrl}">Click here to download the data</a> |
There was a problem hiding this comment.
Nice, a much better way of handling the large files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1608
Changes
covid19-filtered-downloadsbucket. The file will be automatically removed after 3 days. The user will receive an email containing pre signed url to this file (also valid for 3 days) allowing him to download the results. (csv, tsv and json)Email that is being sent with the download link
Alert on data page informing user that the email was sent
