Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manaus parser for SRAG data #1755

Merged
merged 6 commits into from
Jul 2, 2021
Merged

Manaus parser for SRAG data #1755

merged 6 commits into from
Jul 2, 2021

Conversation

AnyaLindstromBattle
Copy link
Contributor

First look at parser which takes Manaus cases in SRAG data.
Please note this is slightly 'bare-bones', i.e. I have included essential data but there is a fair amount more that could go into 'notes'.

Copy link
Contributor

@fojackson8 fojackson8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@Mougk Mougk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2021

Codecov Report

Merging #1755 (bf02f95) into main (80becb5) will increase coverage by 19.79%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1755       +/-   ##
===========================================
+ Coverage   67.54%   87.33%   +19.79%     
===========================================
  Files         127       32       -95     
  Lines        4313      916     -3397     
  Branches     1147      190      -957     
===========================================
- Hits         2913      800     -2113     
+ Misses       1400      116     -1284     
Impacted Files Coverage Δ
data-serving/data-service/src/controllers/case.ts 80.46% <0.00%> (+1.85%) ⬆️
data-serving/data-service/src/index.ts 95.65% <100.00%> (+5.65%) ⬆️
data-serving/data-service/src/model/case.ts 100.00% <0.00%> (ø)
data-serving/data-service/src/util/search.ts 100.00% <0.00%> (ø)
data-serving/data-service/src/util/validate-env.ts 100.00% <0.00%> (ø)
...rving/data-service/src/controllers/preprocessor.ts 100.00% <0.00%> (ø)
...ice/ui/src/components/landing-page/ErrorDialog.tsx
...src/components/common-form-fields/FormikFields.tsx
...ice/ui/src/components/landing-page/LandingPage.tsx
...i/src/components/common-form-fields/AppTooltip.tsx
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a49c7f...bf02f95. Read the comment docs.

@AnyaLindstromBattle
Copy link
Contributor Author

@Mougk @fojackson8 Re-wrote this to allow for ingestion of all data, not just from Manaus. Note I've only tested it locally as e2e not set up yet.

@abhidg abhidg merged commit f2d5129 into main Jul 2, 2021
@abhidg abhidg deleted the manaus branch July 2, 2021 20:28
abhidg added a commit that referenced this pull request Jul 5, 2021
* Manaus parser for SRAG data

* parsing.brazil_manaus.manaus: Use newer Batch functions

* Changes to parser to allow parsing of data from all Brazil

* Fix parsing_lib import in Manaus parser

Co-authored-by: Abhishek Dasgupta <abhishek.dasgupta@cs.ox.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants