#1851 s3 retrieval #1908
Merged
#1851 s3 retrieval #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1908 +/- ##
=======================================
Coverage 75.56% 75.56%
=======================================
Files 24 24
Lines 880 880
Branches 138 138
=======================================
Hits 665 665
Misses 215 215 Continue to review full report at Codecov.
|
jim-sheldon
approved these changes
Jun 8, 2021
This reverts commit bf31f4c.
abhidg
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change is in the ingestion library; neither the UI nor API validate the structure of the source URI so they don't care whether the scheme is
s3://or not.