fix ingestion #1955
Merged
fix ingestion #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhidg
commented
Jun 18, 2021
abhidg
commented
- parsing: Default to has_stable_ids = True
- parsing: Pass headers and cookies to fix 403
While the correct behaviour is to have stable ids False since that is the case for the majority of the sources, setting this to True temporarily before #1954 is fixed. Handling sources without stable ids automatically requires new curator API endpoints which haven't been merged to -stable yet.
|
Didn't we want unstable IDs to be the default? |
|
Ah OK I read the comments. |
iamleeg
added a commit
that referenced
this pull request
Jul 16, 2021
iamleeg
added a commit
that referenced
this pull request
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.