Upgrade docker publish action to v2 #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followed migration instructions at https://github.com/docker/build-push-action/blob/master/UPGRADE.md
abhidg
approved these changes
Jun 29, 2021
| VERSION=${GITHUB_REF#refs/tags/} | ||
| elif [[ $GITHUB_REF == refs/heads/* ]]; then | ||
| VERSION=$(echo ${GITHUB_REF#refs/heads/} | sed -r 's#/+#-#g') | ||
| elif [[ $GITHUB_REF == refs/pull/* ]]; then |
There was a problem hiding this comment.
This won't be called as we are not building on PR, but okay to leave it I guess
There was a problem hiding this comment.
Yup, I pasted that from the example docs and just deleted the outputs that I don't think we need, missed that bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed migration instructions at https://github.com/docker/build-push-action/blob/master/UPGRADE.md
I didn't touch the ingestion functions deployment as that's using a different workflow. Not sure how to test this without tagging or merging though.